Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSS-491 - optimize overlay #129

Draft
wants to merge 47 commits into
base: feature/popover
Choose a base branch
from

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Dec 20, 2023

Description

This PR update serves two purposes: update the popover to never leave the screen regardless of orientation and to add pds-popover within pds-tooltip as the popover content. This will establish a pattern of how to use pds-popover within other components. floating-ui is used as the solution to ensure that performance for fixed position recalculations are optimized to not affect the consuming application.

Dependancies:

  • @floating-ui/dom
  • @floating-ui/core

Fixes DSS-491

Type of change

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Visit the Popover page and verify that the popover is always visible regardless of placement option

  • Visit the Tooltip page and verify that it still functions as expected, since this should have behave differently

  • unit tests

  • e2e tests

  • accessibility tests

  • tested manually

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

libs/core/package.json
  • @floating-ui/core@^1.5.2
  • @floating-ui/dom@^1.5.3
package-lock.json

@QuintonJason QuintonJason changed the title Feature/dss 491 optimize overlay floating UI DSS-491 - optimize overlay Dec 21, 2023
@QuintonJason QuintonJason self-assigned this Dec 22, 2023
@QuintonJason QuintonJason changed the base branch from feature/DSS-462-popover to feature/popover January 23, 2024 18:50
@QuintonJason QuintonJason force-pushed the feature/DSS-491-optimize-overlay-floating-ui branch from c84813e to 1c833d0 Compare January 24, 2024 00:43
@github-actions github-actions bot added enhancement New feature or request package: core Changes have been made to the Core package labels Jan 24, 2024
@ju-Skinner ju-Skinner force-pushed the feature/popover branch 2 times, most recently from 0ff7bd0 to a04782e Compare February 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants