-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSS-491 - optimize overlay #129
Draft
QuintonJason
wants to merge
47
commits into
feature/popover
Choose a base branch
from
feature/DSS-491-optimize-overlay-floating-ui
base: feature/popover
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DSS-491 - optimize overlay #129
QuintonJason
wants to merge
47
commits into
feature/popover
from
feature/DSS-491-optimize-overlay-floating-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Fileslibs/core/package.json
package-lock.json
|
QuintonJason
changed the title
Feature/dss 491 optimize overlay floating UI
DSS-491 - optimize overlay
Dec 21, 2023
QuintonJason
changed the base branch from
feature/DSS-462-popover
to
feature/popover
January 23, 2024 18:50
…for overlay action list content
…n in other components
QuintonJason
force-pushed
the
feature/DSS-491-optimize-overlay-floating-ui
branch
from
January 24, 2024 00:43
c84813e
to
1c833d0
Compare
github-actions
bot
added
enhancement
New feature or request
package: core
Changes have been made to the Core package
labels
Jan 24, 2024
ju-Skinner
force-pushed
the
feature/popover
branch
2 times, most recently
from
February 27, 2024 17:28
0ff7bd0
to
a04782e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update serves two purposes: update the popover to never leave the screen regardless of orientation and to add
pds-popover
withinpds-tooltip
as the popover content. This will establish a pattern of how to usepds-popover
within other components.floating-ui
is used as the solution to ensure that performance forfixed
position recalculations are optimized to not affect the consuming application.Dependancies:
@floating-ui/dom
@floating-ui/core
Fixes DSS-491
Type of change
Please delete options that are not relevant.
If your type of change is not present, add that option.
How Has This Been Tested?
Visit the Popover page and verify that the popover is always visible regardless of
placement
optionVisit the Tooltip page and verify that it still functions as expected, since this should have behave differently
unit tests
e2e tests
accessibility tests
tested manually
Test Configuration:
Checklist:
If not applicable, leave options unchecked.